Skip to content

Fix clash:// deep link not opening app due to premature Activity finish#718

Open
xiwangly2 wants to merge 1 commit intoMetaCubeX:mainfrom
xiwangly2:main
Open

Fix clash:// deep link not opening app due to premature Activity finish#718
xiwangly2 wants to merge 1 commit intoMetaCubeX:mainfrom
xiwangly2:main

Conversation

@xiwangly2
Copy link
Copy Markdown

Problem

When opening a clash://install-config?url=... deep link, the app would flash briefly or appear to not open at all.

Root Cause

In ExternalControlActivity.onCreate(), the ACTION_VIEW branch launches an async coroutine to create the profile and then start PropertiesActivity. However, after the when block, there is an unconditional return finish() at the end of onCreate(). Since launch {} returns immediately, the Activity was being destroyed before the coroutine completed — causing startActivity() to be called on an already-finished Activity.

Fix

Added a return statement after the launch {} block in the ACTION_VIEW branch to prevent execution from falling through to the premature finish(). The coroutine now manages the Activity lifecycle itself, calling finish() after startActivity() succeeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant